workflow: Allow passing API into testing utility functions #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to do some cleanup still |
|
echarrod
approved these changes
Feb 20, 2025
NeilLuno
reviewed
Feb 21, 2025
| @@ -22,6 +22,11 @@ func TriggerCallbackOn[Type any, Status StatusType, Payload any]( | |||
| panic("TriggerCallbackOn can only be used for testing") | |||
| } | |||
|
|
|||
| w, ok := api.(*Workflow[Type, Status]) | |||
There was a problem hiding this comment.
This makes my spidey sense tingle a little. Why can't waitFor accept an API[Type, Status]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for users to return a workflow.API from a function and still use the testing functions as long as the underlying type is a *workflow.Workflow and not, for instance, a mock implementation.