🔍️ Only set callback url if not root

[lukevella]

Summary by CodeRabbit

• Bug Fixes
  • Improved login redirection logic to prevent unnecessary callback URL setting when accessing the root path.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2025 8:02pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
landing	⬜️ Skipped (Inspect)			Jan 27, 2025 8:02pm

[coderabbitai]

Walkthrough

The middleware in the web application has been updated to modify the logic for setting the callbackUrl search parameter during redirection. The key change involves adding a condition that prevents setting the callback URL when the user is attempting to access the root path ("/"). This adjustment impacts the login redirection process by excluding the root path from being used as a callback destination.

Changes

File	Change Summary
apps/web/src/middleware.ts	Modified redirection logic to skip setting callbackUrl for root path ("/")

Poem

🐰 A middleware hop, a routing tweak,
Where root path now plays a sneaky peek
No callback set, a clever design
Redirecting paths with a rabbit's fine line
Login's journey, now more precise and neat! 🔀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af6f7b6 and a39f64e.

📒 Files selected for processing (1)

• apps/web/src/middleware.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Unit tests
• GitHub Check: Integration tests
• GitHub Check: Type check
• GitHub Check: Linting

🔇 Additional comments (2)

apps/web/src/middleware.ts (2)

42-44: LGTM! Good UX improvement.

This change prevents unnecessary callback URL setting when accessing the root path, which is a sensible improvement to the authentication flow.

---

42-44: Verify handling of path variations.

Please verify the behavior with different path variations:

• Root path with trailing slash "/"
• Normalized paths that resolve to root

✅ Verification successful

Path handling implementation is correct ✅

The code safely handles path variations as it relies on Next.js's built-in path normalization, which automatically handles:

• Root path with trailing slash
• Normalized paths that resolve to root
• Multiple slashes and dot segments

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for path normalization and trailing slash handling in the codebase
echo "Checking for path normalization handling..."
rg -l "normalize.*path|path.*normalize" 

echo "Checking for trailing slash handling..."
rg -l "trailing.*slash|slash.*trailing"

echo "Checking NextJS configuration for trailing slashes..."
fd -t f "next.config" -x cat {}

Length of output: 6513

---

Script:

#!/bin/bash
# Check the middleware implementation for path handling
echo "Checking middleware implementation..."
cat apps/web/src/middleware.ts

echo -e "\nChecking for URL/path manipulation in the codebase..."
rg -g '!*.lock' -g '!*.md*' "pathname.*=|\.pathname" -A 2

Length of output: 10072

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.