Feature/30 migrate issuelist to a fragment tab #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues-listing' into develop
…estiny at click on the repository item
…creating its fragments, and joining everything at repo_detail_tablayout
…ne issue detected: RecyclerView - No layout manager attached
…t to fragment_issues_list
luisfernandezbr
requested changes
Apr 17, 2019
| } | ||
|
|
||
| private fun setupArguments() { | ||
| owner = arguments!!.getString("OWNER") |
There was a problem hiding this comment.
Poderia adicionar como constante.
| else -> PullRequestsFragment() | ||
| } | ||
|
|
||
| fragment.arguments = bundle |
There was a problem hiding this comment.
Acho que isso pode dar problemas nos casos de onRestoreInstance(). Vamos aguardar após o merge e testamos juntos.
added 3 commits
April 17, 2019 15:54
…er. Using OWNER and REPONAME as constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issues screen as item of tabbed screen.