-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/30 migrate issuelist to a fragment tab #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n2oliver
wants to merge
16
commits into
luisfernandezbr:develop
Choose a base branch
from
n2oliver:feature/30-migrate-issuelist-to-a-fragment-tab
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/30 migrate issuelist to a fragment tab #31
n2oliver
wants to merge
16
commits into
luisfernandezbr:develop
from
n2oliver:feature/30-migrate-issuelist-to-a-fragment-tab
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues-listing' into develop
…estiny at click on the repository item
…creating its fragments, and joining everything at repo_detail_tablayout
…ne issue detected: RecyclerView - No layout manager attached
…t to fragment_issues_list
luisfernandezbr
requested changes
Apr 17, 2019
} | ||
|
||
private fun setupArguments() { | ||
owner = arguments!!.getString("OWNER") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poderia adicionar como constante.
else -> PullRequestsFragment() | ||
} | ||
|
||
fragment.arguments = bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acho que isso pode dar problemas nos casos de onRestoreInstance(). Vamos aguardar após o merge e testamos juntos.
…er. Using OWNER and REPONAME as constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issues screen as item of tabbed screen.