Skip to content

Feature/30 migrate issuelist to a fragment tab #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

n2oliver
Copy link
Collaborator

New issues screen as item of tabbed screen.

}

private fun setupArguments() {
owner = arguments!!.getString("OWNER")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poderia adicionar como constante.

else -> PullRequestsFragment()
}

fragment.arguments = bundle
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que isso pode dar problemas nos casos de onRestoreInstance(). Vamos aguardar após o merge e testamos juntos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants