Feature/28 adding navigation screen of repository content by tabs #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues-listing' into develop
…estiny at click on the repository item
…creating its fragments, and joining everything at repo_detail_tablayout
luisfernandezbr
requested changes
Apr 17, 2019
| val fragmentAdapter = RepoDetailsPagerAdapter(supportFragmentManager) | ||
| repo_detail_viewpager.adapter = fragmentAdapter | ||
|
|
||
| repo_detail_tablayout.setupWithViewPager(repo_detail_viewpager) |
There was a problem hiding this comment.
Ideal é seguir o padrão de nomenclatura de ids nas views:
buttonSubmit
ao invés de
submit_button
app/src/main/res/values/strings.xml
Outdated
| @@ -8,4 +8,7 @@ | |||
| <string name="error_message_invalid_language">"Ohh no!\n%s is an invalid language\nPlease query a valid language ;)"</string> | |||
|
|
|||
| <string name="button_try_again">TRY AGAIN</string> | |||
|
|
|||
| <!-- TODO: Remove or change this placeholder text --> | |||
| <string name="hello_blank_fragment">Hello blank fragment</string> | |||
There was a problem hiding this comment.
Esse código ficou sobrando?
|
|
||
| override fun getPageTitle(position: Int): CharSequence? { | ||
| return when(position){ | ||
| 0 -> "PullRequests" |
There was a problem hiding this comment.
Será que não faria mais sentido adicionarmos esses textos no arquivo de strings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tabbed screen activity was added to the project to improve the navigation experience, and the click target on the repository item was changed to the RepoDetailsActivity activity. The repo_detail_viewpager received the RepoDetailsPagerAdapter adapter with the five fragments - to know PullRequestsFragment, IssuesFragment, CommitsFragment, CollaboratorsFragment, BranchesFragment - and was added to the repo_detail_tablayout. This will enable the creation of a details screen with a great user browsing experience.