-
Notifications
You must be signed in to change notification settings - Fork 4
GUI Boilerplate and Computer Case GUI Beginnings #17
base: master-MC1.16
Are you sure you want to change the base?
Conversation
|
I would like to keep it as variable as there is not really a change between tthe caseses expact the slots |
… in `Components.kt`
Slots are not working properly yet because the `CaseScreenHandler` is seemingly created twice per GUI opening. Once from `CaseEntity` and once from its registration in`Components.kt`. The latter is generic across Case tiers, and so right now passes in 0 for the tier, which causes an array index out of bounds error.
|
Remeber to update this pr i made big changes (every tecblock is now an blockwithentity) |
|
I'm working on updating it now, but the new |
… tier to affect slot layout
|
Hm, slots seem to have scaling issues. I tried to fix it with no luck. |
|
I look into it after im done with my work related stuff |
|
I'm currently copying code from upstream, let's see if that works! |
|
|
|
Awesome, thanks @jmi2k! |
|
@jmi2k Just checking in on this. I don't think I've seen a PR from you, unless I'm missing something! |
|
Its in https://github.com/jmi2k/OpenComputers/tree/fix-ui |
|
@rschulman can't you see it here? Did I do something wrong? It's the first time I send PR to different repos from the same fork, maybe I messed up something. |
|
@jmi2k as in the readme i had teamed up with the Creator of OpenComputers to help bring OpenComputers 2 for Forge & Fabric |
|
Wait there is a v2 of OC in the works! That's amazing! |
Yes its now a Linux Computer that has a lua runtime |

This draft PR puts in place a few GUI necessities and adds an almost complete case GUI. It does raise some questions about whether we want to make the different case tiers different classes entirely or continue to make them just variables within one class.