APOLLO-23097: Support querying aliases #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of Spark-solr (via SolrRelation) specify the collection they want to query using the 'collection' config parameter. Prior to this commit, this value did not support aliases: it was used directly to lookup core urls since it was always a concrete collections. This commit rewrites this logic, so that aliases can be passed into 'collection' directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of Spark-solr (via SolrRelation) specify the collection they want
to query using the 'collection' config parameter. Prior to this commit,
this value did not support aliases: it was used directly to lookup core
urls since it was always a concrete collections.
This commit rewrites this logic, so that aliases can be passed into
'collection' directly.