fix: no ref in for parse

lucasteles · Dec 28, 2022 · 11aabf1 · 11aabf1
1 parent 8acf1de
commit 11aabf1
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 11 deletions.
diff --git a/src/BrazilModels.csproj b/src/BrazilModels.csproj
@@ -24,7 +24,7 @@
     <PackageReadmeFile>README.md</PackageReadmeFile>
   </PropertyGroup>
   <ItemGroup>
-    <None Include="..\..\README.md" Pack="true" PackagePath="\"/>
+    <None Include="..\README.md" Pack="true" PackagePath="\"/>
   </ItemGroup>
 
   <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">

diff --git a/src/Cnpj.cs b/src/Cnpj.cs
@@ -117,7 +117,7 @@ public static explicit operator Cnpj(in string value)
     /// <exception cref="ArgumentNullException">
     /// Throws a ArgumentNullException if the passed <para name="value" /> is null.
     /// </exception>
-    public static Cnpj Parse(in string value)
+    public static Cnpj Parse(string value)
     {
         ArgumentNullException.ThrowIfNull(value);
         return !TryParse(value, out var cnpj)
@@ -133,7 +133,7 @@ public static Cnpj Parse(in string value)
     /// contains a valid Cnpj. If the method returns false, result equals Empty.
     /// </param>
     /// <returns> true if the parse operation was successful; otherwise, false.</returns>
-    public static bool TryParse(in string value, out Cnpj result)
+    public static bool TryParse(string value, out Cnpj result)
     {
         var normalized = Format(value);
         if (!Validate(normalized))

diff --git a/src/Cpf.cs b/src/Cpf.cs
@@ -115,7 +115,7 @@ public static explicit operator Cpf(in string value)
     /// <exception cref="ArgumentNullException">
     /// Throws a ArgumentNullException if the passed <para name="value" /> is null.
     /// </exception>
-    public static Cpf Parse(in string value)
+    public static Cpf Parse(string value)
     {
         ArgumentNullException.ThrowIfNull(value);
         return !TryParse(value, out var cpf)
@@ -131,7 +131,7 @@ public static Cpf Parse(in string value)
     /// contains a valid Cpf. If the method returns false, result equals Empty.
     /// </param>
     /// <returns> true if the parse operation was successful; otherwise, false.</returns>
-    public static bool TryParse(in string value, out Cpf result)
+    public static bool TryParse(string value, out Cpf result)
     {
         var normalized = Format(value, withMask: false);
         if (!Validate(normalized))

diff --git a/src/TaxId.cs b/src/TaxId.cs
@@ -98,7 +98,8 @@ public TaxId(in ReadOnlySpan<char> value)
     /// <returns>Tax Id as string</returns>
     public string ToString(bool withMask) => Format(Value, Type, withMask);
 
-    static Exception TaxIdException(in ReadOnlySpan<char> value) => new FormatException($"Invalid TaxId: {value}");
+    static Exception TaxIdException(in ReadOnlySpan<char> value) =>
+        new FormatException($"Invalid TaxId: {value}");
 
     /// <summary>
     /// Convert Tax Id to string representation without mask
@@ -107,6 +108,22 @@ public TaxId(in ReadOnlySpan<char> value)
     /// <returns>Tax Id as string</returns>
     public static implicit operator string(in TaxId taxId) => taxId.Value;
 
+    /// <summary>
+    /// Convert Cnpj to TaxId representation without mask
+    /// </summary>
+    /// <param name="cnpj">A Tax Id structure</param>
+    /// <returns>Tax Id as string</returns>
+    public static implicit operator TaxId(in Cnpj cnpj) => new(cnpj.Value);
+
+
+    /// <summary>
+    /// Convert Cpf to TaxId representation without mask
+    /// </summary>
+    /// <param name="cpf">A Tax Id structure</param>
+    /// <returns>Tax Id as string</returns>
+    public static implicit operator TaxId(in Cpf cpf) => new(cpf.Value);
+
+
     /// <summary>
     /// Convert Tax Id to ReadOnlySpan representation without mask
     /// </summary>
@@ -139,7 +156,7 @@ public static explicit operator TaxId(in string value)
     /// <exception cref="ArgumentNullException">
     /// Throws a ArgumentNullException if the passed <para name="value" /> is null.
     /// </exception>
-    public static TaxId Parse(in string value)
+    public static TaxId Parse(string value)
     {
         ArgumentNullException.ThrowIfNull(value);
         return new TaxId(value);
@@ -153,7 +170,7 @@ public static TaxId Parse(in string value)
     /// contains a valid TaxId. If the method returns false, result equals Empty.
     /// </param>
     /// <returns> true if the parse operation was successful; otherwise, false.</returns>
-    public static bool TryParse(in string value, out TaxId result)
+    public static bool TryParse(string value, out TaxId result)
     {
         var type = Validate(value);
         if (type is null)
@@ -167,9 +184,12 @@ public static bool TryParse(in string value, out TaxId result)
     }
 
     /// <inheritdoc />
-    public int CompareTo(TaxId other) => string.Compare(Value, other.Value, StringComparison.OrdinalIgnoreCase);
+    public int CompareTo(TaxId other) =>
+        string.Compare(Value, other.Value, StringComparison.OrdinalIgnoreCase);
 
-    string DebuggerDisplay() => Value == Empty ? "WARNING: INVALID TAX ID!" : $"Tax Id{{{Format(Value, Type, true)}}}";
+    string DebuggerDisplay() => Value == Empty
+        ? "WARNING: INVALID TAX ID!"
+        : $"Tax Id{{{Format(Value, Type, true)}}}";
 
     /// <summary>
     /// Validate given TaxId
@@ -205,7 +225,8 @@ public static string Format(in ReadOnlySpan<char> value, bool withMask = false)
     /// <param name="type">TaxId Type</param>
     /// <param name="withMask">if true, returns formatted TaxId with mask</param>
     /// <returns>Formatted Tax Id string</returns>
-    public static string Format(in ReadOnlySpan<char> value, TaxIdType? type, bool withMask = false) =>
+    public static string Format(in ReadOnlySpan<char> value, TaxIdType? type,
+        bool withMask = false) =>
         type switch
         {
             TaxIdType.CNPJ => Cnpj.Format(value, withMask),