Fix zip file task issue when project root is used as output directory… #21
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fixes luca992#20 The wildcard that was used in the include was too permissive and would cause too many things to be zipped when the output directory was set to be the project root.
|
Sorry, I never saw this. I'll take a look soon and put up a snapshot at least if you want before that |
|
Just checking in on this, did you ever get time to look into this? @luca992 |
|
Sorry I forgot again 😬. Do you want me to put a snapshot up first? |
|
Or do you already know it works as you describe? |
|
I'll trust you on it. If it breaks things someone will let me know 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…. Fixes #20
The wildcard that was used in the include was too permissive and would cause too many things to be zipped when the output directory was set to be the project root.
See issue #20 for more info.