Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
diffTextbattery, that implements a myers-diff esque algorithm using the notion of an edit graph. An edit graph is can be described as:Myers-diff works by greedily following diagonal edges (n,n -> n+1,n+1) but the algorithm is not super intuitive / readable imo.
This implementation stays consistent with the greedy nature but varies slightly in how the graph is traversed. We use a deque to BFS the edit graph in a greedy fashion: whenever a node has a diagonal edge, we push it to the front of the deque, while other edges are always pushed to the back.
I included the
dequeimplementation as a separate battery, since I figure it could provide other use down the line.Both
diffTextanddequehave solid test coverage.Here is what the output of
examples/diffText.luaulooks like: