feature: Lute test runs all the tests #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vighnesh-V
force-pushed
the
lute-test-all
branch
from
0e3d536 to
9edae30
Compare
Vighnesh-V
force-pushed
the
lute-test-all
branch
2 times, most recently
from
ef2f7da to
a53a809
Compare
Vighnesh-V
force-pushed
the
lute-test-all
branch
from
a53a809 to
285ce59
Compare
Vighnesh-V
force-pushed
the
lute-test-all
branch
2 times, most recently
from
9c2d5a3 to
cfdac1b
Compare
vrn-sn
pushed a commit
that referenced
this pull request
Nov 12, 2025
This use after free manifested intermittently when running lots and lots of tests at a time in this PR: #557. The cause of this uaf happens because we do not close the `fs_event_t` handle. When the `WatchHandle` wrapper gets closed, it invoked `uv_event_stop` but not `uv_close`, so the memory associated with the handle gets freed, but `libuv` doesn't know that this handle is closed. This causes uv's internal data structures to get messed up and we may accidentally touch this freed memory causing the Use-After-Free. `WatchHandle::close` already invokes `uv_event_stop`, so we can remove this from the implementation of `closeHandle`.
Vighnesh-V
force-pushed
the
lute-test-all
branch
5 times, most recently
from
0c42ac0 to
61d24e8
Compare
Vighnesh-V
force-pushed
the
lute-test-all
branch
from
61d24e8 to
b60b8ef
Compare
Vighnesh-V
force-pushed
the
lute-test-all
branch
from
92ae627 to
57fa911
Compare
…errors in runner Revert ci.yml changes
Vighnesh-V
force-pushed
the
lute-test-all
branch
from
f8090c5 to
da7cfdc
Compare
Vighnesh-V
commented
Dec 3, 2025
Comment on lines
+47
to
+48
| suite:case("lute test runs tests in discovery folder", function(assert) | ||
| -- Run lute test on tests/cli/discovery folder |
Collaborator
Author
There was a problem hiding this comment.
if we dont do this, lute test calls itself recursively.
Vighnesh-V
force-pushed
the
lute-test-all
branch
from
da7cfdc to
053487e
Compare
Vighnesh-V
force-pushed
the
lute-test-all
branch
from
053487e to
827a3be
Compare
annieetang
approved these changes
Dec 3, 2025
Contributor
annieetang
left a comment
annieetang
left a comment
There was a problem hiding this comment.
could u make a note about why we aren't using this in CI for now? or a follow up issue for it
Collaborator
Author
|
Created a follow up issue for running this in CI here: #634. I'm going to spend some time tomorrow digging into this to figure out exactly why the @Batteries require fails with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run all the tests in your project via:
Run some of the tests in a directory via: