Implement POST /auth/google/disconnect handler (LEY-16)#13
Merged
Conversation
- Replace 501 stub with a full implementation using JwtAuthenticatedAppUserProvider to extract userId from the verified JWT sub claim - Call clearRefreshToken() to set status=revoked and null the encrypted token, preserving the connection record for auditing - Return 200 on success, 404 when no connection exists (ConditionalCheckFailedException), 401 when unauthenticated, and rethrow unexpected errors - Add 4 unit tests: 401 unauthenticated, 200 success, 404 not found, rethrow on unknown error Closes LEY-16
- Add docs/auth0-setup.md with step-by-step Auth0 tenant setup instructions covering API creation, Google social connection, test application, and the SAM parameter values required for deployment - Update docs/gmail-connection-contracts.md to replace stale header-based auth references with the current Auth0 JWT boundary: API Gateway verifies the JWT, Lambda reads userId from the injected sub claim Closes LEY-17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
POST /auth/google/disconnectendpoint which previously returned 501. Authenticated users can now revoke their Gmail connection.Changes
src/handlers/disconnectGoogleOAuth.tswith a full implementation:JwtAuthenticatedAppUserProviderto extractuserIdfrom the verified JWTsubclaimgmailConnectionRepository.clearRefreshToken()to null the encrypted token and set status torevoked— preserves the record for auditing200on success,404when no connection exists (ConditionalCheckFailedException),401when unauthenticatedstartGoogleOAuthandgoogleOAuthCallbacksrc/handlers/disconnectGoogleOAuth.test.tswith 4 tests: 401 unauthenticated, 200 success with correct DynamoDB call, 404 not found, rethrow on unexpected errorTest results
pnpm exec tsc --noEmitpasses clean.Closes LEY-16