Conversation
- Add JwtClaims type to types.ts for the Auth0 JWT authorizer context shape - Add JwtAuthenticatedAppUserProvider that reads userId from event.requestContext.authorizer.jwt.claims.sub (verified by API Gateway) - Remove HeaderAuthenticatedAppUserProvider and the unsafe x-authenticated-user-id header - Update startGoogleOAuth and googleOAuthCallback handlers to use APIGatewayProxyEventV2WithJWTAuthorizer event type - Add unit tests covering valid sub, missing sub, non-string sub, and empty sub cases - Update startGoogleOAuth.test.ts event fixture to use JWT requestContext shape Closes LEY-15
The header-based provider is fully replaced by JwtAuthenticatedAppUserProvider. No remaining imports or references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the unsafe
x-authenticated-user-idheader with the verified JWTsubclaim injected by API Gateway after Auth0 token validation.Changes
JwtClaimstype tosrc/types.tsrepresenting the Auth0 JWT authorizer claims shapesrc/services/jwtAuthenticatedAppUserProvider.ts— readsuserIdfromevent.requestContext.authorizer.jwt.claims.sub, which is populated by API Gateway only after a valid JWT has been verifiedHeaderAuthenticatedAppUserProviderand thex-authenticated-user-idheader entirelystartGoogleOAuth.tsandgoogleOAuthCallback.tsto useAPIGatewayProxyEventV2WithJWTAuthorizerevent type throughoutJwtAuthenticatedAppUserProvidercovering: valid sub, missing sub, non-string sub, and empty string substartGoogleOAuth.test.tsevent fixture to use JWTrequestContextshapeTest results
pnpm exec tsc --noEmitpasses clean.Closes LEY-15