DM-47507: Add workflow for triggering ConsDB migrations #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyMcCormick
force-pushed
the
tickets/DM-47507
branch
2 times, most recently
from
953f23d to
781f744
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-47507
branch
from
781f744 to
a4c3a24
Compare
JeremyMcCormick
changed the title
JeremyMcCormick
force-pushed
the
tickets/DM-47507
branch
from
a4c3a24 to
aa19eac
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-47507
branch
2 times, most recently
from
5bb4ef0 to
f7e6172
Compare
ktlim
previously approved these changes
Nov 16, 2024
.github/workflows/migrate.yaml
Outdated
|
|
||
| on: | ||
| pull_request: | ||
| types: [closed] |
There was a problem hiding this comment.
Why not just do merges to main?
There was a problem hiding this comment.
I do not know how to get the name of the branch that is being merged if it triggers on pushes to main. As far as I can tell, only the commit SHA is available in that case. From the PR trigger, this is easily accessible information. (If you have a suggestion on how to do this, I can incorporate it.)
.github/workflows/migrate.yaml
Outdated
| - name: Trigger migration workflow in consdb repository | ||
| run: | | ||
| curl -X POST \ | ||
| -H "Authorization: token ${{ secrets.REPO_DISPATCH_TOKEN }}" \ |
There was a problem hiding this comment.
We have a service account rubinobs-dm-admin that can be used to create this token.
JeremyMcCormick
force-pushed
the
tickets/DM-47507
branch
from
f7e6172 to
e28b5c6
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-47507
branch
from
e28b5c6 to
91832c4
Compare
JeremyMcCormick
changed the title
JeremyMcCormick
force-pushed
the
tickets/DM-47507
branch
from
91832c4 to
2f974fb
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-47507
branch
3 times, most recently
from
7cf58f1 to
fc84b92
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-47507
branch
from
fc84b92 to
3203714
Compare
JeremyMcCormick
dismissed
ktlim’s stale review
This workflow is not functioning properly right now and needs to be re-reviewed after changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workflow which triggers automatic creation of migrations scripts in the consdb repo using repository dispatch. It activates on closed and merged PRs on which there were changes to
cdb_*.yamlschemas requiring migrations to be generated. This is done usingfelis diff --comparator alembicso that changes which do not result in updates to the logical data model in the database will be ignored and not dispatched toconsdb.Do not merge until lsst/felis#109 is merged.