DM-50038: Fix DcrMultiband technical debt #1103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abudlong
force-pushed
the
tickets/DM-50038
branch
from
28ed7be to
535dfcc
Compare
sr525
reviewed
Apr 17, 2025
| storageClass="ExposureF", | ||
| dimensions=("tract", "patch", "band", "subfilter", "skymap"), | ||
| ) | ||
|
|
There was a problem hiding this comment.
These names should probably be updated to be consistent with the new names
There was a problem hiding this comment.
What do you mean by the "new names?"
sr525
reviewed
Apr 17, 2025
| doc="Input schema for measure merged task produced by a deblender or detection task", | ||
| name="deepCoadd_deblendedFlux_schema", | ||
| storageClass="SourceCatalog", | ||
| # dimensions=("tract", "patch", "band", "skymap") |
There was a problem hiding this comment.
Seems to be a lot of things commented out here, these should be removed if not needed.
abudlong
force-pushed
the
tickets/DM-50038
branch
3 times, most recently
from
d270ad4 to
6815f1c
Compare
abudlong
force-pushed
the
tickets/DM-50038
branch
from
24ecb03 to
37c1d70
Compare
abudlong
force-pushed
the
tickets/DM-50038
branch
6 times, most recently
from
d5e4f24 to
522d39f
Compare
abudlong
force-pushed
the
tickets/DM-50038
branch
from
cb59af5 to
635240e
Compare
sr525
reviewed
Jul 3, 2025
| from .mergeDetections import MergeDetectionsConfig, MergeDetectionsTask # noqa: F401 | ||
| from .mergeMeasurements import MergeMeasurementsConfig, MergeMeasurementsTask # noqa: F401 | ||
| from .multiBandUtils import CullPeaksConfig # noqa: F401 | ||
| from .deblendCoaddSourcesPipeline import DeblendCoaddSourcesSingleConfig # noqa: F401 |
There was a problem hiding this comment.
All these imports from the same file can go in the same statement.
abudlong
force-pushed
the
tickets/DM-50038
branch
3 times, most recently
from
37dcd28 to
9519a27
Compare
abudlong
force-pushed
the
tickets/DM-50038
branch
2 times, most recently
from
82555ac to
dd8107a
Compare
abudlong
force-pushed
the
tickets/DM-50038
branch
from
dd8107a to
1aa7edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.