DM-34875: Expect Astropy instead of Pandas for objectTable in tests. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
approved these changes
Nov 21, 2024
tests/test_coadd_outputs.py
Outdated
| coadd_coord = geom.SpherePoint(cat["coord_ra"].values[index]*geom.degrees, | ||
| cat["coord_dec"].values[index]*geom.degrees) | ||
| coadd_coord = geom.SpherePoint(cat["coord_ra"][index]*geom.degrees, | ||
| cat["coord_dec"][index]*geom.degrees) |
There was a problem hiding this comment.
This is all fine, but the flexible thing to do is np.asarray(cat["coord_ra"])[index] which will work with any input that supports numpy __array__ access without doing a data copy. (including pandas, astropy, etc)
TallJimbo
force-pushed
the
tickets/DM-34875
branch
from
f48323e to
1615919
Compare
TallJimbo
force-pushed
the
tickets/DM-34875
branch
from
1615919 to
7c8934b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.