Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial push ticket sitcom-1412 #139

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

estevesjh
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@estevesjh estevesjh self-assigned this Jun 27, 2024
@estevesjh estevesjh requested a review from b1quint June 27, 2024 02:07
@b1quint
Copy link
Member

b1quint commented Jul 8, 2024

Hi @estevesjh, It seems that you pushed a notebook with outputs. We want to avoid this at all costs because it will overload the repository with data that should not be there. Please remove the outputs from this notebook, create a new commit, and squash the two commits. This should remove the outputs from the history line.

Alternatively, you can clear the outputs and use the git commit --amend to correct this last commit.

Once you are done with the outputs, remember to do a git force—-push-with-lease to push your updates to GitHub.

An easy way to remove the outputs is by installing the pre-commit command. This will check if your notebooks have outputs or not and will clear them.

@b1quint
Copy link
Member

b1quint commented Jul 8, 2024

I will ask you to add some information about what is intended to be done in this PR. I could not figure out from the ticket. It seems that you are updating a tech note. If this is the case, you want to move the notebook from here to the repo containing the tech note

Copy link
Member

@b1quint b1quint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook contains outputs. It needs to be cleaned up and the commits squashed to ensure we don't have outputs in the history line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants