Add switches to dataset runner scripts #67
Conversation
examples/runCfhtQuickTest.sh
Outdated
| done | ||
| shift $((OPTIND-1)) | ||
|
|
||
| if [ "$DOPROCESS" = true ] ; then |
There was a problem hiding this comment.
Since the shebang line is invoking bash, the improved [[ ]] can be used for testing. Variables do not need to be quoted inside of [[ ]] and == may be used instead of the posix = equality operator.
examples/runCfhtQuickTest.sh
Outdated
| p) DOPROCESS=false;; | ||
| v) DOVERIFY=false;; | ||
| h) usage;; | ||
| *) usage;; |
There was a problem hiding this comment.
Technically, h and * don't need to be separate cases as * will match h but that might be a slightly non-obvious to future maintainers. However, it should be possible to condense these two matches with h | *).
There was a problem hiding this comment.
I'm removing the * as we discussed.
| DOVERIFY=true | ||
|
|
||
| usage() { | ||
| print_error |
There was a problem hiding this comment.
This is down to personal preference but you could replace the multiple print_error calls with.
print_error "$(cat <<-EOF
EOF
)"
There was a problem hiding this comment.
I'd prefer to leave this as is since it's the same as in other scripts in this repo. I'm happy to file a ticket to update the syntax in the future.
These switches allow processing and verification steps to be turned off.
SimonKrughoff
force-pushed
the
u/krughoff/add-switches
branch
from
56dd07c to
812a30d
Compare
These switches allow processing and verification steps to be turned off.
Note that this does not change the default behavior. The switches turn the different aspect off.