Merged
Conversation
- @activeprofiles("test")로 명시적 테스트 프로필 활성화
There was a problem hiding this comment.
Pull Request Overview
이 PR은 CQRS (Command Query Responsibility Segregation) 패턴을 애플리케이션에 적용하기 위해 MySQL Master-Replica 아키텍처를 구축하고 데이터소스를 동적으로 할당하는 기능을 구현합니다.
- MySQL Master-Replica 복제 환경 구축을 위한 Docker 컨테이너 설정
- 트랜잭션의 읽기 전용 여부에 따라 Master/Replica 데이터소스를 동적으로 라우팅하는 설정 구현
- 테스트 환경에서 별도 프로필 활용을 위한 설정 추가
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/com/rabbitmqprac/RabbitMqPracApplicationTests.java | 테스트 클래스에 test 프로필 활성화 어노테이션 추가 |
| src/main/resources/application.yml | 기존 단일 데이터소스를 master/replica 구조로 변경하고 MySQL 방언 설정 추가 |
| src/main/java/com/rabbitmqprac/config/DataSourceConfiguration.java | 트랜잭션 읽기 전용 여부에 따른 데이터소스 라우팅 로직 구현 |
| mysql/setup-replication.sh | MySQL Master-Replica 복제 설정 자동화 스크립트 |
| mysql/replica-data-source.cnf | MySQL Replica 서버 설정 파일 |
| mysql/master-data-source.cnf | MySQL Master 서버 설정 파일 |
| mysql/init-master.sql | Master DB 초기화 및 복제 사용자 생성 스크립트 |
| docker-compose.yml | MongoDB 제거 및 MySQL Master-Replica 컨테이너 구성 추가 |
src/main/java/com/rabbitmqprac/config/DataSourceConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/rabbitmqprac/config/DataSourceConfiguration.java
Outdated
Show resolved
Hide resolved
Owner
Author
📊 Test Coverage Report
|
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⭐ Related issue
📌 Tasks