-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Fix JSON binding error caused by incorrectly quoted empty variables in Bruno
#186
Conversation
WalkthroughThe changes update the pre-request variable definitions across several build job configuration files. Specifically, the default empty string values for Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thank you for fixing this issue :) |
Development
: Fix JSON binding error caused by incorrectly quoted empty variables in Bruno
This PR fixes an issue where variable values like
user: ""
andpassword: ""
in Bruno were resulting in double-quoted strings (e.g.""""
) after template replacement, which broke JSON validity during request execution.By removing the surrounding quotes in the variable definitions (e.g. changing
user: ""
touser:
), Bruno correctly replaces them with empty strings (""
), producing valid JSON.This change ensures successful binding of JSON and avoids runtime errors when submitting build jobs.
Summary by CodeRabbit
These behind-the-scenes updates enhance the processing of authentication details and repository information in the build jobs.