Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix E2E tests condition to run single-node for PRs #10540

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

egekocabas
Copy link
Member

@egekocabas egekocabas commented Mar 20, 2025

Checklist

General

Motivation and Context

Previously, all E2E tests were running as multi-node due to incorrect if conditions in the workflow. The conditions were incorrectly checking github.event.workflow_run.pull_requests, causing the single-node test case to never run.

This PR fixes the logic by correctly checking github.event.workflow_run.event == 'pull_request' to determine if the triggering workflow was caused by a PR. Now:

  • Tests will run on Single-node artemis if the workflow_run event was triggered by a PR.
  • Tests will run on Multi-node artemis if the workflow_run event was triggered by other events (e.g., push to develop, main, release branches, or release).

Description

  • if condition in test-e2e.yml fixed.

Sorry, something went wrong.

@egekocabas egekocabas marked this pull request as ready for review March 20, 2025 22:25
@egekocabas egekocabas requested a review from a team as a code owner March 20, 2025 22:25
@egekocabas egekocabas linked an issue Mar 21, 2025 that may be closed by this pull request
6 tasks
@Mtze Mtze added this to the 8.0 milestone Mar 21, 2025
@Mtze Mtze merged commit fcb3e28 into develop Mar 21, 2025
14 checks passed
@Mtze Mtze deleted the bugfix/fix-e2e-single-multi-node branch March 21, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants