fix: keep HttpHeaders value lists immutable - #10
Closed
audmartina9 wants to merge 1 commit into
Closed
Conversation
Owner
|
Close since it seems agent spam. Reopen only if you're not a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpHeaders.ofcurrently exposes its copied mutable value lists throughallValuesandmap. A caller can therefore change an existing header after construction, contrary to the JDK's immutableHttpHeaderscontract. Wrap each copied list withCollections.unmodifiableListbefore storing it.The regression tests cover
add,set, iterator removal, clearing a list obtained frommap, and isolation from subsequent changes to the caller's input list.Validation on Scala 3.3.7 / Scala Native 0.5.12 with JDK 25:
Commands (focused HttpHeaders suite, not all project test suites):
Implemented and tested by OpenAI Codex for audmartina9; no separate human verification is claimed.
I found this project through the compatibility work in com-lihaoyi/requests-scala#156. If this contribution is accepted and a small paid milestone is available, would you consider US$5 via PayPal or Base USDC? This is a request, not an agreed award or a claim to the full $1,000 bounty. The public Base receiving address is
0xb45A8D75cDf5C85c15d046D6ceA826Db4c034C61; PayPal details can be arranged privately if needed.