Skip to content

Fix spurious aborts when retrying transactions #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix spurious aborts when retrying transactions #279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7e42fa
Fix spurious aborts when retrying transactions
3noch Oct 11, 2019
7d15beb
Only catch SqlError in retryLoop
3noch Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/Database/PostgreSQL/Simple/Transaction.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,20 +157,19 @@ withTransactionModeRetry :: TransactionMode -> (SqlError -> Bool) -> Connection
withTransactionModeRetry mode shouldRetry conn act =
mask $ \restore ->
retryLoop $ E.try $ do
a <- restore act
a <- restore act `E.onException` rollback_ conn
commit conn
return a
where
retryLoop :: IO (Either E.SomeException a) -> IO a
retryLoop :: IO (Either SqlError a) -> IO a
retryLoop act' = do
beginMode mode conn
r <- act'
case r of
Left e -> do
rollback_ conn
case fmap shouldRetry (E.fromException e) of
Just True -> retryLoop act'
_ -> E.throwIO e
Left e ->
case shouldRetry e of
True -> retryLoop act'
False -> E.throwIO e
Right a ->
return a

Expand Down