Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkout event #126

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix checkout event #126

merged 2 commits into from
Oct 30, 2023

Conversation

zxch3n
Copy link
Member

@zxch3n zxch3n commented Oct 30, 2023

The event is wrong when the doc checkouts to a old version that brings back a deleted container.

@zxch3n zxch3n requested a review from Leeeon233 October 30, 2023 05:57
@zxch3n zxch3n added the bug Something isn't working label Oct 30, 2023
@zxch3n zxch3n self-assigned this Oct 30, 2023
@Leeeon233 Leeeon233 linked an issue Oct 30, 2023 that may be closed by this pull request
Need to emit events involving child container re-creation #125
Closed
@zxch3n zxch3n merged commit 734b832 into main Oct 30, 2023
1 check passed
@zxch3n zxch3n deleted the fix-checkout-event branch October 30, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leeeon233 Leeeon233 Leeeon233 approved these changes

Assignees

@zxch3n zxch3n

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to emit events involving child container re-creation
2 participants
@zxch3n @Leeeon233