Feat/unique index #743
Open
Feat/unique index #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaqilniz
force-pushed
the
feat/unique-index
branch
2 times, most recently
from
77b28d1 to
31c0725
Compare
Signed-off-by: Muhammad Aaqil <[email protected]>
aaqilniz
force-pushed
the
feat/unique-index
branch
from
3c891f0 to
3f60fb7
Compare
aaqilniz
requested review from
dhmlau,
achrinza and
marioestradarosa
as code owners
dhmlau
reviewed
Mar 17, 2025
There was a problem hiding this comment.
@aaqilniz, thanks for creating this PR. I've reviewed the changes and had a comment. However, I'm not familiar with postgresql enough to review the main change of this PR (i.e. buildQueryUniqueKeys function). It would be good to have someone like @samarpanB to review. Thanks.
| @@ -276,6 +276,7 @@ CREATE TABLE "user" ( | |||
| email character varying(100) | |||
| ); | |||
|
|
|||
| ALTER TABLE "user" ADD CONSTRAINT user_email_unique UNIQUE (email); | |||
There was a problem hiding this comment.
Is it better to:
ALTER TABLE "user" ADD UNIQUE (email);
Reference: https://www.beekeeperstudio.io/blog/guide-to-unique-constraints-in-postgresql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses on your machine