Skip to content

chore: update strong-globalize #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2020
Merged

chore: update strong-globalize #419

merged 1 commit into from
Mar 20, 2020

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Mar 20, 2020 •
edited
Loading

Related to loopbackio/loopback-next#4585

Update strong-globalize version to 5.x.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@dhmlau
Copy link
Member Author

dhmlau commented Mar 20, 2020

I was trying to update eslint as well, but there are more changes associated with it. So I'll leave this PR to update strong-globalize only and investigate why tests fail when other dependencies are updated.

@dhmlau dhmlau merged commit eaf5d68 into master Mar 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the update2 branch March 20, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnes512 agnes512 agnes512 approved these changes

@b-admike b-admike Awaiting requested review from b-admike

@emonddr emonddr Awaiting requested review from emonddr

@jannyHou jannyHou Awaiting requested review from jannyHou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhmlau @agnes512