chore: update strong-globalize version #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slnode test please |
|
Let's also update supported Node.js versions - see #54 |
dhmlau
force-pushed
the
update-dep
branch
2 times, most recently
from
86542ba to
a0022ef
Compare
nabdelgadir
approved these changes
Apr 29, 2020
agnes512
approved these changes
Apr 29, 2020
jannyHou
reviewed
Apr 29, 2020
There was a problem hiding this comment.
Nitpick: I think the latest is 6.0.1 see https://www.npmjs.com/package/strong-globalize, otherwise LGTM 👍
|
Let's upgrade to the latest strong-globalize version please, especially considering that we no longer support Node.js 8.x thanks to #54 |
jannyHou
approved these changes
Apr 30, 2020
|
Using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to loopbackio/loopback-next#4585.
Update
strong-globalizeversion to 5.x.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine