Skip to content

Conversation

@eilers
Copy link

@eilers eilers commented Sep 8, 2025

I use the keycloak and the keycloak-api-rails gem in my project. This caused some very interesting and subtile issues.

Although I'm aware that renaming the module name is breaking existing code, I really think that the new name is better matching the gem and avoids conflicts.
As the changes in exiting code are very easy to fix, I think this is acceptable.

Thanks for you work btw.. I saved me a lot of time! :)

@looorent
Copy link
Owner

looorent commented Nov 8, 2025

Thank you @eilers for taking the time to submit this PR, and apologies for my late reply.

  • Renaming: I agree that the module renaming makes sense, and I plan to include it in the upcoming major version 1.0.0, as it would be a breaking change for existing code.
  • Translation: However, I am not comfortable merging the changes related to translating error messages with I18n. This project is an attempt to remain dependency-agnostic, so I prefer to avoid introducing services like I18n (even though the i18n gem is already included indirectly through activesupport).

Could you remove the modifications of lib/keycloak-api-rails/middleware.rb from this PR?

@eilers
Copy link
Author

eilers commented Nov 24, 2025

Dear @looorent !
Great to hear that you will incorporate the change.

Could you remove the modifications of lib/keycloak-api-rails/middleware.rb from this PR?

Yes, I'll remove this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants