Skip to content

Conversation

@sushant-suse
Copy link
Contributor

Which issue(s) this PR fixes:

Issue 12252

What this PR does / why we need it:

It updates the Longhorn UI access documentation to be ingress-agnostic. It refactors the Basic Auth guide to remove a hard dependency on ingress-nginx as the sole example, allowing for better compatibility with other controllers like Traefik.

Special notes for your reviewer:

The instructions have been generalized, and the Nginx-specific verification logs have been replaced with standard HTTP response codes. I have also added a specific reference to the Helm values.yaml for Ingress configuration as recommended.

Additional documentation or context:

N/A

@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 48f91a4
🔍 Latest deploy log https://app.netlify.com/projects/longhornio/deploys/695fa3a72b8dc6000891dd8a
😎 Deploy Preview https://deploy-preview-1275--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@derekbit
Copy link
Member

derekbit commented Jan 2, 2026

The original intent of the ticket is to clarify that switching Ingress controllers (e.g. ingress-nginx to Traefik) does not affect Longhorn backend components, and that only the Longhorn UI ingress needs to be reconfigured. Making the document more controller-agnostic. And, the original Basic Auth guide can be an example.

@sushant-suse sushant-suse requested a review from derekbit January 2, 2026 06:21
@derekbit
Copy link
Member

derekbit commented Jan 5, 2026

@sushant-suse Can you consolidate the commits? Focus on the v1.11.0 and port it to v1.10.x and v1.9.x later.

@derekbit
Copy link
Member

derekbit commented Jan 5, 2026

In addition, need to mentioned https://kubernetes.io/blog/2025/11/11/ingress-nginx-retirement/ in the PR.

@derekbit
Copy link
Member

derekbit commented Jan 5, 2026

Please consolidate the commits

image

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check #1275 (comment). The latest PR doesn't address the comment.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Longhorn UI access documentation to be more ingress controller-agnostic by adding notes about the ingress-nginx controller retirement and clarifying that the choice of Ingress controller doesn't affect Longhorn's core functionality.

Key changes:

  • Added deprecation notices referencing a November 2025 Kubernetes announcement about ingress-nginx retirement
  • Added clarifying note that Ingress controller choice only affects UI access, not Longhorn backend operations
  • Minor formatting improvements (blank lines before References section)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
content/docs/1.11.0/deploy/accessing-the-ui/longhorn-ingress.md Added deprecation notice for ingress-nginx and formatting improvement
content/docs/1.11.0/deploy/accessing-the-ui/_index.md Added notes about Ingress controller impact and ingress-nginx retirement
content/docs/1.10.1/deploy/accessing-the-ui/longhorn-ingress.md Minor formatting fix (blank line before References)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 97a7e03 into longhorn:master Jan 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants