-
Notifications
You must be signed in to change notification settings - Fork 198
docs: update ingress control example in doc #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for longhornio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The original intent of the ticket is to clarify that switching Ingress controllers (e.g. ingress-nginx to Traefik) does not affect Longhorn backend components, and that only the Longhorn UI ingress needs to be reconfigured. Making the document more controller-agnostic. And, the original Basic Auth guide can be an example. |
content/docs/1.11.0/deploy/accessing-the-ui/longhorn-ingress.md
Outdated
Show resolved
Hide resolved
|
@sushant-suse Can you consolidate the commits? Focus on the v1.11.0 and port it to v1.10.x and v1.9.x later. |
|
In addition, need to mentioned https://kubernetes.io/blog/2025/11/11/ingress-nginx-retirement/ in the PR. |
content/docs/1.11.0/deploy/accessing-the-ui/longhorn-ingress.md
Outdated
Show resolved
Hide resolved
a76deb9 to
8d220df
Compare
Signed-off-by: sushant-suse <[email protected]>
8d220df to
83ed3ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check #1275 (comment). The latest PR doesn't address the comment.
content/docs/1.11.0/deploy/accessing-the-ui/longhorn-ingress.md
Outdated
Show resolved
Hide resolved
Signed-off-by: sushant-suse <[email protected]>
Signed-off-by: sushant-suse <[email protected]>
content/docs/1.11.0/deploy/accessing-the-ui/longhorn-ingress.md
Outdated
Show resolved
Hide resolved
8d6b0d3 to
187f8e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Longhorn UI access documentation to be more ingress controller-agnostic by adding notes about the ingress-nginx controller retirement and clarifying that the choice of Ingress controller doesn't affect Longhorn's core functionality.
Key changes:
- Added deprecation notices referencing a November 2025 Kubernetes announcement about ingress-nginx retirement
- Added clarifying note that Ingress controller choice only affects UI access, not Longhorn backend operations
- Minor formatting improvements (blank lines before References section)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| content/docs/1.11.0/deploy/accessing-the-ui/longhorn-ingress.md | Added deprecation notice for ingress-nginx and formatting improvement |
| content/docs/1.11.0/deploy/accessing-the-ui/_index.md | Added notes about Ingress controller impact and ingress-nginx retirement |
| content/docs/1.10.1/deploy/accessing-the-ui/longhorn-ingress.md | Minor formatting fix (blank line before References) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: sushant-suse <[email protected]>
187f8e4 to
48f91a4
Compare
derekbit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Which issue(s) this PR fixes:
Issue 12252
What this PR does / why we need it:
It updates the Longhorn UI access documentation to be ingress-agnostic. It refactors the Basic Auth guide to remove a hard dependency on
ingress-nginxas the sole example, allowing for better compatibility with other controllers like Traefik.Special notes for your reviewer:
The instructions have been generalized, and the Nginx-specific verification logs have been replaced with standard HTTP response codes. I have also added a specific reference to the Helm
values.yamlfor Ingress configuration as recommended.Additional documentation or context:
N/A