fix(connector): fix missuse of replyTo field #7062
Open
+22
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the miss use of replyTo field. Should not be used as the alias of to email
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/connectors/connector-mailgun/src/index.test.ts | 📉 -84 Bytes |
| packages/connectors/connector-mailgun/src/index.ts | 📉 -40 Bytes |
| packages/connectors/connector-sendgrid-email/src/index.test.ts | 📉 -72 Bytes |
| packages/connectors/connector-sendgrid-email/src/index.ts | 📉 -119 Bytes |
| packages/connectors/connector-smtp/src/index.test.ts | 📉 -73 Bytes |
| packages/toolkit/connector-kit/src/types/email-template.ts | 📉 -172 Bytes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix the misuse of the
replyTofield.For some email providers, this field can indicate the reply email address. Previously, it was confused with the alias of send to email address.
Testing
Unit test updated
Checklist
.changeset