Skip to content

Release 0.3.6 - #19

Open
bacv wants to merge 6 commits into
masterfrom
release/0.3.6
Open

bacv wants to merge 6 commits into
masterfrom
release/0.3.6

Conversation

@bacv

@bacv bacv commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Just for inspection

@bacv bacv changed the title Release/0.3.6 Release 0.3.6 Nov 19, 2026
@bacv
bacv requested review from andrussal and pradovic and removed request for andrussal November 19, 2026 20:09

@pradovic pradovic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the zone-sdk side.

@bacv

bacv commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator Author

@andrussal, we need a decision on logos_sql for the 0.3.6 release branch of logos-zone-sdk (PR #19).

The problem

The logos_sql in this repo is the master version, but node 0.3.6 only has a much older one. The 0.3.6 release line branched on Oct 8, and of the 11 logos_sql commits that landed on node master after that, only #3598 and the rusqlite bump (#4038) were backported. So relative to node 0.3.6, this repo's logos_sql additionally carries:

  • batched writes (#3650)
  • throughput work and the settlement benchmark (#3654)
  • bounded SQL execution (#3701)
  • rebuild from ZoneSDK history (#3778)
  • encrypted password manager (#3785)
  • read-only replica resume (#3877)

On the branch the library is ported to the 0.3.6 node APIs (old BinaryCodec derive, no fork digest, fixed inscription size limit instead of the era-based one). It compiles against the 0.3.6 tag and unit tests pass, but it has never run against a real 0.3.6 node.

The cucumber suites are the blocker. tests/logos-sql and tests/zone-sdk depend on the public harness API from the test-suite split (#3847), which was not backported, so at 0.3.6 the functions they call are missing or crate-private. Both crates are currently out of the workspace and CI does not run them.

Options

  1. Backport the harness API to the node 0.3.6 line (#3847 plus the few later harness changes) and pin this repo to that commit or a new tag. Our test crates then run nearly as written, with a small port to 0.3.6 APIs. Needs a node-repo change, and the pin is no longer the plain 0.3.6 tag; the node binary itself is unaffected since only test code changes.
  2. Run the node's own 0.3.6 zone and Logos SQL suites against this repo's crates via a Cargo [patch]. No node change. I tried this and it compiles with one small API change (publication moved out of WriterConfig into a separate start_with_publication). The suites were never actually run in that setup. Our own step and feature files go unused, so master-only scenarios (batching, encrypted password manager) get no end-to-end coverage.
  3. Ship node 0.3.6's logos_sql instead of master's. It is already covered by the node's 0.3.6 suite, but the release loses the six features above.
  4. Vendor the node's 0.3.6 test crate into this repo and open up what we need. No node change, but about 50k lines of copied test code to carry.

My view

Option 1 if we want the master features in 0.3.6 and properly tested; option 3 if 0.3.6 should simply match what the node shipped. Option 2 is a workable middle ground with a coverage gap. I'd avoid 4.

Which logos_sql do you want in 0.3.6, and are you OK with a harness backport on the node release line?

@bacv
bacv requested a review from andrussal November 19, 2026 20:16
@andrussal

Copy link
Copy Markdown
Collaborator

Which logos_sql do you want in 0.3.6, and are you OK with a harness backport on the node release line?

Option 3 sounds good to me. I think the SQL features in the 0.3.6 tag are enough for this release, and we can use the existing harness. All six SQL Cucumber scenarios passed with the old SQL and PR #19’s SDK against a 0.3.6 node. The Zone SDK suite is still running.

@bacv

bacv commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

Option 3 sounds good to me.

Went with option 3 in 8ba0fc0.

  • logos_sql is now an exact copy of node 0.3.6's, so the six master-only features listed above are not in this release.
  • tests/zone-sdk and tests/logos-sql are thin runners that run the node's own 0.3.6 zone and Logos SQL cucumber suites against this repo's crates via a Cargo [patch]. The node's steps compile unchanged.
  • The master-era step and feature files are removed on this branch, since they need the harness API from #3847.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants