Make it possible to hide fields from the table

[fhennig]

resolves #3325

preview URL: http://column-hiding.loculus.org

Summary

• Adds a new metadata config setting: hideInSearchResultsTable which you can set to hide a column in the Column visibility dialog.

Screenshot

Nothing to see really.

PR Checklist

• All necessary documentation has been adapted.
• The implemented feature is covered by an appropriate test.

[theosanderson]

Looks very reasonable to me! If one wanted to test this one way would be:

• add a field with this to e.g. test-organism in values.yaml
• in the integration tests, assert that it is not displayed when you go and list the fields for this organism (and assert that some other field is, as a positive control)

But not demanding that

[fhennig]

Thanks! I added a test, maybe you can have a look again?

Added test, pls view again

[theosanderson]

Nice - formatting issue but otherwise good.

My inclination is that we should aim in say a year's time to have most of what is currently the "E2E" tests instead moved to the "integration" tests, so if I were adding this I'd have probably added it to the integration tests, but I appreciate we don't have e.g. a searchPage set up there so it's more work / less nice. We can probably move whole sets of tests over in due course.

[theosanderson]

huh or maybe the format issue is unrelated?

[fhennig]

My inclination is that we should aim in say a year's time to have most of what is currently the "E2E" tests instead moved to the "integration" tests, so if I were adding this I'd have probably added it to the integration tests, but I appreciate we don't have e.g. a searchPage set up there so it's more work / less nice. We can probably move whole sets of tests over in due course.

Ah! I'll keep that in mind. I'd tend to agree actually.