Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename and surface sraRunAccession #3524

Merged
merged 2 commits into from
Jan 20, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ena-submission/test/approved_ena_submission_list_test.json
Original file line number Diff line number Diff line change
@@ -57,7 +57,7 @@
"hostHealthState": "Hospital care required",
"ncbiReleaseDate": null,
"ncbiVirusTaxId": null,
"sraRunAccession": null,
"insdcRawReadsAccession": null,
"environmentalSite": null,
"signsAndSymptoms": null,
"anatomicalMaterial": null,
2 changes: 1 addition & 1 deletion ena-submission/test/external_metadata_test.ndjson
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"accession": "LOC1", "version": 1, "externalMetadata": {"ncbiReleaseDate": null,"ncbiUpdateDate": null,"ncbiSubmitterCountry": null,"insdcAccessionBase": null,"insdcVersion": null,"insdcAccessionFull": null,"bioprojectAccession": null,"biosampleAccession": null,"ncbiSourceDb": null,"ncbiVirusName": null,"ncbiVirusTaxId": null,"sraRunAccession": null}}
{"accession": "LOC1", "version": 1, "externalMetadata": {"ncbiReleaseDate": null,"ncbiUpdateDate": null,"ncbiSubmitterCountry": null,"insdcAccessionBase": null,"insdcVersion": null,"insdcAccessionFull": null,"bioprojectAccession": null,"biosampleAccession": null,"ncbiSourceDb": null,"ncbiVirusName": null,"ncbiVirusTaxId": null,"insdcRawReadsAccession": null}}
4 changes: 2 additions & 2 deletions ingest/tests/config_cchf/config.yaml
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ insdc_segment_specific_fields:
- insdcAccessionBase
- insdcVersion
- insdcAccessionFull
- sraRunAccession
- insdcRawReadsAccession
keycloak_token_url: http://localhost:8083/realms/loculus/protocol/openid-connect/token
nextclade_dataset_name: nextstrain/cchfv/linked
nextclade_dataset_server: https://raw.githubusercontent.com/nextstrain/nextclade_data/cornelius-cchfv/data_output
@@ -23,7 +23,7 @@ rename:
ncbiHostTaxId: hostTaxonId
ncbiIsLabHost: isLabHost
ncbiIsolateName: specimenCollectorSampleId
ncbiSraAccessions: sraRunAccession
ncbiSraAccessions: insdcRawReadsAccession
ncbiSubmitterAffiliation: authorAffiliations
ncbiSubmitterNames: authors
taxon_id: 3052518
12 changes: 6 additions & 6 deletions ingest/tests/expected_output_cchf/metadata_post_prepare.json
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
"sampleCollectionDate": "1989",
"segment": "L",
"specimenCollectorSampleId": "K229_194",
"sraRunAccession": "",
"insdcRawReadsAccession": "",
"submissionId": "KX013462.1"
},
"KX013463.1": {
@@ -46,7 +46,7 @@
"sampleCollectionDate": "1989",
"segment": "M",
"specimenCollectorSampleId": "K229_194",
"sraRunAccession": "",
"insdcRawReadsAccession": "",
"submissionId": "KX013463.1"
},
"KX013464.1": {
@@ -71,7 +71,7 @@
"sampleCollectionDate": "1989",
"segment": "S",
"specimenCollectorSampleId": "K229_194",
"sraRunAccession": "",
"insdcRawReadsAccession": "",
"submissionId": "KX013464.1"
},
"KX013483.1": {
@@ -96,7 +96,7 @@
"sampleCollectionDate": "1958",
"segment": "L",
"specimenCollectorSampleId": "Nakiwogo",
"sraRunAccession": "",
"insdcRawReadsAccession": "",
"submissionId": "KX013483.1"
},
"KX013485.1": {
@@ -121,7 +121,7 @@
"sampleCollectionDate": "1958",
"segment": "S",
"specimenCollectorSampleId": "Nakiwogo",
"sraRunAccession": "",
"insdcRawReadsAccession": "",
"submissionId": "KX013485.1"
},
"KX096703.1": {
@@ -146,7 +146,7 @@
"sampleCollectionDate": "2015",
"segment": "S",
"specimenCollectorSampleId": "tick pool #134",
"sraRunAccession": "",
"insdcRawReadsAccession": "",
"submissionId": "KX096703.1"
}
}
4 changes: 2 additions & 2 deletions kubernetes/loculus/values.yaml
Original file line number Diff line number Diff line change
@@ -1053,8 +1053,8 @@ defaultOrganismConfig: &defaultOrganismConfig
hideOnSequenceDetailsPage: true
noInput: true
header: "INSDC"
- name: sraRunAccession
displayName: SRA run accession
- name: insdcRawReadsAccession
displayName: Raw reads accession
customDisplay:
type: link
url: "https://www.ncbi.nlm.nih.gov/sra/?term=__value__"