Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow disabling data use terms #3468

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: Allow disabling data use terms #3468

wants to merge 3 commits into from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 18, 2024

resolves #3127

preview URL:

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fhennig
Copy link
Contributor Author

fhennig commented Dec 18, 2024

As was discussed earlier, here are the code places marked where I think changes will be introduced to implement this feature.

@corneliusroemer you wanted to have a look first. Putting this on hold till then.

cc @chaoran-chen

@theosanderson
Copy link
Member

Would the backend not need any changes?

@fhennig
Copy link
Contributor Author

fhennig commented Dec 18, 2024

That wasn't in the ticket I think. But maybe that was a mistake? I remember that we talked about that too actually. I'd be curious to look into how to do that

@theosanderson
Copy link
Member

My guess (maybe wrong) of what would happen if you made the changes annotated would be:

  • backend would still expect data use terms on submission so would give an error
  • backend would still emit data use terms in get-released-data so SILO would get confused at the unexpected field

@chaoran-chen
Copy link
Member

We need to do some changes so that (1) the backend accepts submissions that don't provide a data use term and (2) don't expose it in get-released-data. But if it make things easier, it could write "open" into the database.

@fhennig
Copy link
Contributor Author

fhennig commented Dec 18, 2024

Ah, makes sense

@fhennig
Copy link
Contributor Author

fhennig commented Dec 18, 2024

that should cover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable data use terms
3 participants