Frontend(navbar): Enhance Mobile Navigation with Sheet Component #368#384
Frontend(navbar): Enhance Mobile Navigation with Sheet Component #368#384violaberg wants to merge 6 commits intolmcrean:mainfrom
Conversation
|
@violaberg is attempting to deploy a commit to the lmcrean's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@lmcrean, @josephk-O , @adi-ray Could have a look at changes I've made so far so someone else can take over and finish mobile nav. |
I see you haven't pushed the changes yet |
|
@adi-ray let me see if I forgot to push |
|
@adi-ray Yeah, I never pushed. Some code is commented out for now as I didn't finish it but eslint errors wouldn't let me push otherwise of course |
|
bump @dev-rafiu |
i guess i can go ahead then. @violaberg |
|
Sure, go ahead! |
Adjustments to the current basic mobile dropdown menu with a modern Sheet/Drawer component to provide a better mobile user experience and replace current implementation of a simple dropdown with slide-in drawer.
Screenshots / Screen Recordings
Original mobile nav:
Updated mobile nav:
How to Test
Please provide step-by-step testing instructions. If any specific test data or test accounts are needed, mention them here.
README-developers.mdChecklist
Before submitting this PR, the following must be confirmed:
mainbranch and resolved any merge conflictscd frontend && npm run buildto confirm no type or build errorsnpm run lint) and fixed warnings/errorsRan it alright and got almost 20k errors, didn't fix. added new issue for UserIcon ESlint errors: Fix ESLint Errors in UserIcon.tsx #395
Issue Links
Closes Frontend(navbar): Enhance Mobile Navigation with Sheet Component #368
Additional Notes
Not sure if we should change icon colour to white, especially for Profile link, might be contrast issue