Skip to content

Add REQUIRES Double and XFAIL AMD to WaveActiveMax.fp64 #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 3, 2025
Merged

Add REQUIRES Double and XFAIL AMD to WaveActiveMax.fp64 #544

merged 5 commits into from
Dec 3, 2025
+5 −0

Conversation

@Icohedron
Copy link
Contributor

@Icohedron Icohedron commented Dec 2, 2025 •
edited
Loading

AMD (#541) XFAIL on DirectX.
Add a REQUIRES: Double to fix #542, since the QC machine doesn't appear to support fp64

╭────┬──────────────────────┬─────────────┬──────────────────────────────┬────────┬─────────────────────────────────╮
│  # │      timestamp       │   run-id    │           workflow           │ status │              test               │
├────┼──────────────────────┼─────────────┼──────────────────────────────┼────────┼─────────────────────────────────┤
│  0 │ 2025-12-02T12:01:06Z │ 19857858903 │ Windows D3D12 AMD DXC        │ FAIL   │ WaveOps/WaveActiveMax.fp64.test │
│  1 │ 2025-12-02T16:08:39Z │ 19865261556 │ Windows D3D12 QC DXC         │ FAIL   │ WaveOps/WaveActiveMax.fp64.test │
│  2 │ 2025-12-02T18:02:48Z │ 19868627852 │ Windows Vulkan QC DXC        │ FAIL   │ WaveOps/WaveActiveMax.fp64.test │
│  3 │ 2025-12-02T12:11:34Z │ 19858143265 │ Windows D3D12 Warp DXC       │ PASS   │ WaveOps/WaveActiveMax.fp64.test │
│  4 │ 2025-12-02T16:01:35Z │ 19865037929 │ Windows D3D12 Intel DXC      │ PASS   │ WaveOps/WaveActiveMax.fp64.test │
│  5 │ 2025-12-02T16:03:51Z │ 19865110582 │ Windows D3D12 NVIDIA DXC     │ PASS   │ WaveOps/WaveActiveMax.fp64.test │
│  6 │ 2025-12-02T16:00:59Z │ 19865018538 │ Windows ARM64 D3D12 Warp DXC │ PASS   │ WaveOps/WaveActiveMax.fp64.test │
│  7 │ 2025-12-02T12:07:36Z │ 19858035043 │ Windows Vulkan AMD DXC       │ PASS   │ WaveOps/WaveActiveMax.fp64.test │
│  8 │ 2025-12-02T16:02:15Z │ 19865059004 │ Windows Vulkan Intel DXC     │ PASS   │ WaveOps/WaveActiveMax.fp64.test │
│  9 │ 2025-12-02T16:07:41Z │ 19865230599 │ Windows Vulkan NVIDIA DXC    │ PASS   │ WaveOps/WaveActiveMax.fp64.test │
│ 10 │ 2025-12-02T17:09:41Z │ 19867100359 │ macOS Metal DXC              │ XFAIL  │ WaveOps/WaveActiveMax.fp64.test │
╰────┴──────────────────────┴─────────────┴──────────────────────────────┴────────┴─────────────────────────────────╯

@Icohedron Icohedron added the test-all When applied to a PR this will opt-in to additional pre-merge test configurations.. label Dec 2, 2025
@Icohedron Icohedron closed this Dec 2, 2025
@Icohedron Icohedron reopened this Dec 2, 2025
bogner
bogner reviewed Dec 2, 2025
View reviewed changes
test/WaveOps/WaveActiveMax.fp64.test
# XFAIL: Metal

# Bug https://github.com/llvm/offload-test-suite/issues/541
# XFAIL: DirectX && AMD
Copy link
Collaborator

@bogner bogner Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this is limited to AMD - I also see this test fail locally for me on nVidia and I would've expected that we need llvm/llvm-project#169430 for it to pass anywhere...

Copy link
Contributor Author

@Icohedron Icohedron Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an existing XFAIL on Clang for this test. The failure on AMD is specific to DXC for DirectX. But I assume if DXC is failing, then Clang would fail as well if it were implemented, so I omitted DXC from the new XFAIL condition.

Copy link
Collaborator

@bogner bogner Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't notice the Clang XFAIL.

@Icohedron Icohedron changed the title Update XFAILs of WaveActiveMax and WaveActiveMax.fp64 Update XFAILs of WaveActiveMax.fp64 Dec 2, 2025
@Icohedron Icohedron changed the title Update XFAILs of WaveActiveMax.fp64 Add REQUIRES Double and XFAIL AMD to WaveActiveMax.fp64 Dec 2, 2025
bogner
bogner approved these changes Dec 2, 2025
View reviewed changes
test/WaveOps/WaveActiveMax.fp64.test
# XFAIL: Metal

# Bug https://github.com/llvm/offload-test-suite/issues/541
# XFAIL: DirectX && AMD
Copy link
Collaborator

@bogner bogner Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't notice the Clang XFAIL.

@Icohedron Icohedron enabled auto-merge (squash) December 3, 2025 00:38
@Icohedron Icohedron disabled auto-merge December 3, 2025 16:58
@Icohedron Icohedron merged commit 3deeaba into llvm:main Dec 3, 2025
9 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogner bogner bogner approved these changes

@inbelic inbelic inbelic approved these changes

Assignees

No one assigned

Labels

test-all When applied to a PR this will opt-in to additional pre-merge test configurations..

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test WaveOps/WaveActiveMax.fp64.test fails on Qualcomm for D3D12 and Vulkan

3 participants

@Icohedron @bogner @inbelic