[compiler-rt] Add SPIR-V target support for UBSan Minimal Runtime #195979
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
|
|
||
| #include "ubsan_minimal_common.h" | ||
|
Contributor
There was a problem hiding this comment. Not a fan of splitting this up so arbitrarily, I don't know what SPIR-V does that can't be done by improving the set of compiler builtins
Contributor
Author
There was a problem hiding this comment. The
Contributor
There was a problem hiding this comment. I guess I don't really understand how the SPIR-V build is supposed to work, but why do we have both C libcalls and stuff like __builtin_spirv_num_workgroups(0)? I generally prefer the latter.
Contributor
Author
There was a problem hiding this comment. I've updated the file to use the |
||
|
|
||
| #include <stdlib.h> | ||
| #include <string.h> | ||
|
|
||
| #if defined(__ANDROID__) | ||
| extern "C" __attribute__((weak)) void android_set_abort_message(const char *); | ||
| #endif // defined(__ANDROID__) | ||
|
|
||
| #ifdef KERNEL_USE | ||
| extern "C" void ubsan_message(const char *msg); | ||
| static void message(const char *msg) { ubsan_message(msg); } | ||
| #elif defined(SANITIZER_AMDGPU) || defined(SANITIZER_NVPTX) | ||
| #include <stdio.h> | ||
| static void message(const char *msg) { fprintf(stderr, "%s", msg); } | ||
| #else | ||
| #include <unistd.h> | ||
| static void message(const char *msg) { (void)write(2, msg, strlen(msg)); } | ||
| #endif | ||
|
|
||
| static char *append_str(const char *s, char *buf, const char *end) { | ||
| for (const char *p = s; (buf < end) && (*p != '\0'); ++p, ++buf) | ||
| *buf = *p; | ||
| return buf; | ||
| } | ||
|
|
||
| static char *append_hex(uintptr_t d, char *buf, const char *end) { | ||
| // Print the address by nibbles. | ||
| for (unsigned shift = sizeof(uintptr_t) * 8; shift && buf < end;) { | ||
| shift -= 4; | ||
| unsigned nibble = (d >> shift) & 0xf; | ||
| *(buf++) = nibble < 10 ? nibble + '0' : nibble - 10 + 'a'; | ||
| } | ||
| return buf; | ||
| } | ||
|
|
||
| static void format_msg(const char *kind, uintptr_t caller, char *buf, | ||
| const char *end) { | ||
| buf = append_str("ubsan: ", buf, end); | ||
| buf = append_str(kind, buf, end); | ||
| buf = append_str(" by 0x", buf, end); | ||
| buf = append_hex(caller, buf, end); | ||
| buf = append_str("\n", buf, end); | ||
| if (buf == end) | ||
| --buf; // Make sure we don't cause a buffer overflow. | ||
| *buf = '\0'; | ||
| } | ||
|
|
||
| void __ubsan_message(const char *msg) { | ||
| message(msg); | ||
| } | ||
|
|
||
| void __ubsan_message(const char *kind, uintptr_t caller) { | ||
| char buf[128]; | ||
| format_msg(kind, caller, buf, buf + sizeof(buf)); | ||
| message(buf); | ||
| } | ||
|
|
||
| void __ubsan_abort() { | ||
| abort(); | ||
| } | ||
|
|
||
| void __ubsan_abort_with_message(const char *kind, uintptr_t caller) { | ||
| char buf[128]; | ||
| format_msg(kind, caller, buf, buf + sizeof(buf)); | ||
|
|
||
| #if defined(__ANDROID__) | ||
| if (&android_set_abort_message) | ||
| android_set_abort_message(buf); | ||
| #else // defined(__ANDROID__) | ||
| message(buf); | ||
| #endif // defined(__ANDROID__) | ||
|
|
||
| abort(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| #include "ubsan_minimal_common.h" | ||
|
|
||
| #define __gpu_constant __attribute__((opencl_constant)) | ||
|
|
||
| using size_t3 = size_t [[clang::ext_vector_type(3)]]; | ||
| struct __ubsan_abort_info_t { | ||
| __gpu_constant const char *fmt; | ||
| const char *kind; | ||
| uintptr_t caller; | ||
| size_t3 gid; | ||
| size_t3 lid; | ||
| }; | ||
|
|
||
| // OpenCL printf maps to OpExtInst printf (OpenCL extended instruction set). | ||
| extern "C" int printf(__gpu_constant const char *fmt, ...); | ||
|
|
||
| // SPV_KHR_abort: OpAbortKHR terminates the invocation and passes a message | ||
| // to the client API. The message is passed as a typed value. | ||
| [[noreturn]] void __spirv_AbortKHR(__ubsan_abort_info_t info); | ||
|
|
||
| static __gpu_constant const char ubsan_msg_simple[] = "%s"; | ||
| static __gpu_constant const char ubsan_msg_fmt[] = | ||
| "ubsan: %s by 0x%lx at gid=[%v3lu] lid=[%v3lu]\n"; | ||
|
|
||
| void __ubsan_message(const char *msg) { printf(ubsan_msg_simple, msg); } | ||
|
|
||
| void __ubsan_message(const char *kind, uintptr_t caller) { | ||
| size_t3 gid = {__builtin_spirv_workgroup_id(0), | ||
| __builtin_spirv_workgroup_id(1), | ||
| __builtin_spirv_workgroup_id(2)}; | ||
| size_t3 lid = {__builtin_spirv_local_invocation_id(0), | ||
| __builtin_spirv_local_invocation_id(1), | ||
| __builtin_spirv_local_invocation_id(2)}; | ||
|
|
||
| printf(ubsan_msg_fmt, kind, caller, gid, lid); | ||
| } | ||
|
|
||
| [[noreturn]] void __ubsan_abort() { __ubsan_abort_with_message("abort", 0); } | ||
|
|
||
| [[noreturn]] void __ubsan_abort_with_message(const char *kind, | ||
| uintptr_t caller) { | ||
| size_t3 gid = {__builtin_spirv_workgroup_id(0), | ||
| __builtin_spirv_workgroup_id(1), | ||
| __builtin_spirv_workgroup_id(2)}; | ||
| size_t3 lid = {__builtin_spirv_local_invocation_id(0), | ||
| __builtin_spirv_local_invocation_id(1), | ||
| __builtin_spirv_local_invocation_id(2)}; | ||
|
|
||
| __ubsan_abort_info_t info = {ubsan_msg_fmt, kind, caller, gid, lid}; | ||
| __spirv_AbortKHR(info); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| //===-- ubsan_minimal_common.h ----------------------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This file is a part of the minimal UB sanitizer runtime. | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef UBSAN_MINIMAL_COMMON_H | ||
| #define UBSAN_MINIMAL_COMMON_H | ||
|
|
||
| #if defined(__UINTPTR_TYPE__) && defined(__SIZE_TYPE__) | ||
| typedef __UINTPTR_TYPE__ uintptr_t; | ||
| typedef __SIZE_TYPE__ size_t; | ||
|
|
||
| static_assert(sizeof(uintptr_t) == sizeof(void *), | ||
| "uintptr_t must be the same size as void*"); | ||
| #else // defined(__UINTPTR_TYPE__) && defined(__SIZE_TYPE__) | ||
| #include <stdint.h> | ||
| #endif // defined(__UINTPTR_TYPE__) && defined(__SIZE_TYPE__) | ||
|
|
||
| void __ubsan_message(const char *msg); | ||
| void __ubsan_message(const char *kind, uintptr_t caller); | ||
|
|
||
| [[noreturn]] void __ubsan_abort(); | ||
| [[noreturn]] void __ubsan_abort_with_message(const char *kind, | ||
| uintptr_t caller); | ||
|
|
||
| #endif // UBSAN_MINIMAL_COMMON_H |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why