[flang][runtime] fix intrinsics case of extends_type_of #161466
+33
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
klausler
reviewed
Oct 1, 2025
| RT_API_ATTRS bool IsPointer() const { | ||
| return raw_.attribute == CFI_attribute_pointer; | ||
| } | ||
| RT_API_ATTRS bool IsAssociated() const { return raw_.base_addr != nullptr; } |
There was a problem hiding this comment.
Isn't there already a predicate member function in Descriptor for a non-null base address?
| // versions of this code that would probably execute faster. | ||
| // F'23 16.9.86 p 5 | ||
| // If MOLD is unlimited polymorphic and is either a disassociated pointer or | ||
| // unallocated allocatable variable, the result is true; |
There was a problem hiding this comment.
This can be simplified and corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155459 by making sure the cases are considered in the right order. Previously intrinsics types where overriding the pointer cases which have higher precedence in the specification.
Also passes the following tests.