Skip to content

[NFC][LLVM-Tests] Specialize test suite for LLVM unit tests #161442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2025
+7 −2
Merged

[NFC][LLVM-Tests] Specialize test suite for LLVM unit tests #161442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79fb9ac
[NFC][LLVM-Tests] Specialize test suite for LLVM unit tests
jurahul Sep 30, 2025
60d3d02
Merge branch 'main' into nfc_specialize_unit_tests
jurahul Sep 30, 2025
b9cb3cb
Merge branch 'main' into nfc_specialize_unit_tests
jurahul Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ set(LLVM_TEST_DEPENDS
${LLVM_TEST_DEPENDS_COMMON}
BugpointPasses
LLVMWindowsDriver
UnitTests
bugpoint
llc
lli
Expand Down Expand Up @@ -270,10 +269,11 @@ add_lit_testsuites(LLVM ${CMAKE_CURRENT_SOURCE_DIR}
${exclude_from_check_all}
DEPENDS ${LLVM_TEST_DEPENDS}
FOLDER "Tests/Subdirectories"
SKIP "^FileCheck" "^TableGen"
SKIP "^FileCheck" "^TableGen" "^Unit"
)
add_subdirectory(FileCheck)
add_subdirectory(TableGen)
add_subdirectory(Unit)

# Setup an alias for 'check-all'.
add_custom_target(check)
Expand Down
5 changes: 5 additions & 0 deletions llvm/test/Unit/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
add_lit_testsuite(check-llvm-unit "Running lit suite for LLVM unit tests"
${CMAKE_CURRENT_BINARY_DIR}
EXCLUDE_FROM_CHECK_ALL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it unconditional EXCLUDE_FROM_CHECK_ALL? It looks conditional on the left.

Copy link
Contributor Author

@jurahul jurahul Oct 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See similar PR for the earlier specialized suites: #159781

Without EXCLUDE_FROM_CHECK_ALL, these tests run twice, which is wasteful and sometimes leading to failure due to concurrent execution (which will likely not affect these unit tests).

DEPENDS UnitTests
)