Skip to content

Conversation

svkeerthy
Copy link
Contributor

No description provided.

@svkeerthy svkeerthy marked this pull request as ready for review August 12, 2025 00:15
@llvmbot llvmbot added mlgo llvm:analysis Includes value tracking, cost tables and constant folding labels Aug 12, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 12, 2025

@llvm/pr-subscribers-llvm-analysis

@llvm/pr-subscribers-mlgo

Author: S. VenkataKeerthy (svkeerthy)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/153094.diff

1 Files Affected:

  • (modified) llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json (+1)
diff --git a/llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json b/llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json
index bb97a491dfe8a..fcc1344ada314 100644
--- a/llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json
+++ b/llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json
@@ -47,6 +47,7 @@
         "FPTrunc": [0, 0, 0],
         "FPExt": [0, 0, 0],
         "PtrToInt": [0, 0, 0],
+        "PtrToAddr": [0, 0, 0],
         "IntToPtr": [0, 0, 0],
         "BitCast": [0, 0, 0],
         "AddrSpaceCast": [0, 0, 0],

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't missed. It's new (patch landed last week I think).

Either way, LGTM.

Copy link
Contributor Author

Yes. The patch added "PtrToAddr" in all the other vocab files but this.

@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-merging_ir2vec_categories branch from 44c5895 to de8480b Compare August 25, 2025 22:59
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch from 265222b to 8ce3c84 Compare August 25, 2025 22:59
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch from 8ce3c84 to d6cc948 Compare August 27, 2025 19:40
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-merging_ir2vec_categories branch 2 times, most recently from 11de2dc to cbc8c9e Compare August 27, 2025 20:06
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch from d6cc948 to 3680f38 Compare August 27, 2025 20:06
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-merging_ir2vec_categories branch from cbc8c9e to 4da0ac5 Compare August 27, 2025 21:04
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch from 3680f38 to 5dc4c48 Compare August 27, 2025 21:04
Copy link
Contributor Author

svkeerthy commented Aug 28, 2025

Merge activity

  • Aug 28, 6:26 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 28, 7:12 PM UTC: The Graphite merge of this pull request was cancelled.
  • Aug 29, 7:31 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 29, 8:04 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 29, 8:05 PM UTC: @svkeerthy merged this pull request with Graphite.

@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-merging_ir2vec_categories branch from 4da0ac5 to b71c5ee Compare August 28, 2025 19:58
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch 2 times, most recently from 3e10c63 to bd8e431 Compare August 28, 2025 23:04
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-merging_ir2vec_categories branch 2 times, most recently from b131bef to 7495b65 Compare August 28, 2025 23:52
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch 2 times, most recently from 0d1fb80 to 3cdc0d5 Compare August 29, 2025 00:37
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-merging_ir2vec_categories branch from 7495b65 to 829eb24 Compare August 29, 2025 00:37
Base automatically changed from users/svkeerthy/08-11-merging_ir2vec_categories to main August 29, 2025 18:49
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch from 3cdc0d5 to a5fc0c3 Compare August 29, 2025 18:51
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch from a5fc0c3 to 6dea185 Compare August 29, 2025 19:31
@svkeerthy svkeerthy merged commit c13de14 into main Aug 29, 2025
9 checks passed
@svkeerthy svkeerthy deleted the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch August 29, 2025 20:05
@llvm-ci
Copy link
Collaborator

llvm-ci commented Aug 29, 2025

LLVM Buildbot has detected a new failure on builder ml-opt-devrel-x86-64 running on ml-opt-devrel-x86-64-b2 while building llvm at step 4 "cmake-configure".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/175/builds/24376

Here is the relevant piece of the build log for the reference
Step 4 (cmake-configure) failure: cmake (failure)
...
-- Failed to find LLVM FileCheck
-- Google Benchmark version: v0.0.0, normalized to 0.0.0
-- Looking for shm_open in rt
-- Looking for shm_open in rt - found
-- Performing Test HAVE_CXX_FLAG_WALL
-- Performing Test HAVE_CXX_FLAG_WALL - Success
-- Performing Test HAVE_CXX_FLAG_WEXTRA
-- Performing Test HAVE_CXX_FLAG_WEXTRA - Success
-- Performing Test HAVE_CXX_FLAG_WSHADOW
-- Performing Test HAVE_CXX_FLAG_WSHADOW - Success
-- Performing Test HAVE_CXX_FLAG_WFLOAT_EQUAL
-- Performing Test HAVE_CXX_FLAG_WFLOAT_EQUAL - Success
-- Performing Test HAVE_CXX_FLAG_WOLD_STYLE_CAST
-- Performing Test HAVE_CXX_FLAG_WOLD_STYLE_CAST - Success
-- Performing Test HAVE_CXX_FLAG_WSUGGEST_OVERRIDE
-- Performing Test HAVE_CXX_FLAG_WSUGGEST_OVERRIDE - Success
-- Performing Test HAVE_CXX_FLAG_PEDANTIC
-- Performing Test HAVE_CXX_FLAG_PEDANTIC - Success
-- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS
-- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS - Success
-- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32
-- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32 - Success
-- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING
-- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING - Success
-- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS
-- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS - Success
-- Performing Test HAVE_CXX_FLAG_FNO_EXCEPTIONS
-- Performing Test HAVE_CXX_FLAG_FNO_EXCEPTIONS - Success
-- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING
-- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING - Success
-- Performing Test HAVE_CXX_FLAG_WD654
-- Performing Test HAVE_CXX_FLAG_WD654 - Failed
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY - Success
-- Enabling additional flags: -DINCLUDE_DIRECTORIES=/b/ml-opt-devrel-x86-64-b1/llvm-project/third-party/benchmark/include
-- Compiling and running to test HAVE_THREAD_SAFETY_ATTRIBUTES
-- Performing Test HAVE_THREAD_SAFETY_ATTRIBUTES -- success
-- Performing Test HAVE_CXX_FLAG_COVERAGE
-- Performing Test HAVE_CXX_FLAG_COVERAGE - Success
-- Compiling and running to test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Compiling and running to test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- success
-- Compiling and running to test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK -- success
-- Compiling and running to test HAVE_PTHREAD_AFFINITY
-- Performing Test HAVE_PTHREAD_AFFINITY -- success
-- Configuring incomplete, errors occurred!
See also "/b/ml-opt-devrel-x86-64-b1/build/CMakeFiles/CMakeOutput.log".
See also "/b/ml-opt-devrel-x86-64-b1/build/CMakeFiles/CMakeError.log".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:analysis Includes value tracking, cost tables and constant folding mlgo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants