Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sub-channel quantized type documentation #133765

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

sdasgup3
Copy link
Contributor

fixes the issue reported in #120172 (comment)

@llvmbot
Copy link
Member

llvmbot commented Mar 31, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-quant

Author: Sandeep Dasgupta (sdasgup3)

Changes

fixes the issue reported in #120172 (comment)


Full diff: https://github.com/llvm/llvm-project/pull/133765.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Quant/IR/QuantBase.td (+1)
diff --git a/mlir/include/mlir/Dialect/Quant/IR/QuantBase.td b/mlir/include/mlir/Dialect/Quant/IR/QuantBase.td
index 0d97889960019..23bf5cf15e256 100644
--- a/mlir/include/mlir/Dialect/Quant/IR/QuantBase.td
+++ b/mlir/include/mlir/Dialect/Quant/IR/QuantBase.td
@@ -279,6 +279,7 @@ def Quant_Dialect : Dialect {
     // Correct. The quantized type now includes 3 scale values, matching the
     // size of dimension 1 of the result tensor.
     %result = quant.qcast %input : tensor<?x3xf32> to tensor<?x3x!quant.uniform<i8:f32:1, {2.0, 3.0, 4.0}>>
+    ```
 
     ## Sub-channel quantization integrity
 

@GleasonK GleasonK merged commit eefefb5 into llvm:main Mar 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants