[CIR] Early return in emitCXXTryStmt if try block is empty #1944
+36
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the case of an empty try block, we emit tryOp in scope and revisit the catchers, and in the lowering pass, we have a check to delete empty scopes, but we end up with scopes that contains
cir.yeild
or an unconditioned jump to another scope which will not be deleted, also for catchers we emits globals for type info.But we can already ignore the try-catch statement if the try block is empty, because that means also all catchers are dead code, which will lead to not emitting any scopes that we know will be removed later and also not emitting any unnecessary type info
Example of current emitted IR: https://godbolt.org/z/5d3jEe5K8