No custom printer for CompReg - leading to loss of quotation marks Resolves #8833 #9049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2025 23:00
|
Hey @KaiS987, sorry for taking so long to fire off CI. Thanks for taking a stab at fixing this 🥳! It looks like a few of your changes might have gotten lost along the way, e.g. actually invoking the custom parser/printer from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that compreg didn’t have a custom printer, so it was using the default format. That format wasn’t handling quoting correctly. The solution was to add a small custom parser and printer for the optional inner symbol attribute. Resolves #8833