[FIRRTL] Make Domains ClassLike #9032
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
dev/seldridge/firrtl-make-domains-class-like
branch
from
64f2628 to
f4d176c
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-erase-domains
branch
from
9f28b09 to
76e8bbd
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-make-domains-class-like
branch
2 times, most recently
from
da4b15c to
071ea2b
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-erase-domains
branch
from
76e8bbd to
bffc683
Compare
dtzSiFive
reviewed
Oct 2, 2025
| ArrayRef<Attribute> DomainOp::getPortAnnotations() { return {}; } | ||
|
|
||
| void DomainOp::setPortAnnotationsAttr(ArrayAttr annotations) { | ||
| llvm_unreachable("domains do not support annotations"); |
There was a problem hiding this comment.
Consider report fatal error instead? I don't know why this would be unreachable.
cc #3836 .
We don't want compilers being told this is unreachable, as that means anything reaching it is also "unreachable" and can to bizarre behaviors, like eliding branches/checks entirely knowing they lead to unreachable code.
OTOH that's exactly what it's good for.
I see that we do this for the ClassOp definitions, which hopefully is almost exactly a copy of :), so leaving it as-is is fine.
Since presumably it is presently unreachable.
There was a problem hiding this comment.
Yeah, this is all copied from the ClassOp definitions. I agree that this isn't great.
seldridge
force-pushed
the
dev/seldridge/firrtl-erase-domains
branch
from
4ab6d85 to
39455de
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-make-domains-class-like
branch
5 times, most recently
from
8aede17 to
206c1e8
Compare
Change domains to behave almost exactly like classes. They now have input and outputs (which can be used by their existing bodies). This could alternatively be solved by using a simpler representation for domains. However, this would be better handled with a full cleanup of how classes are modeled. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/firrtl-make-domains-class-like
branch
from
206c1e8 to
73f465c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change domains to behave almost exactly like classes. They now have
input and outputs (which can be used by their existing bodies).
This could alternatively be solved by using a simpler representation for
domains. However, this would be better handled with a full cleanup of how
classes are modeled.
TODO:
LowerDomains. (64f2628)This is stacked on #8929.