Skip to content

[ESI] Unpack dictionary arguments for CallbackPort callbacks #8916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ESI] Unpack dictionary arguments for CallbackPort callbacks #8916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/Dialect/ESI/runtime/python/esiaccel/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,14 @@ def type_convert_wrapper(cb: Callable[[Any], Any],
(obj, leftover) = self.arg_type.deserialize(msg)
if len(leftover) != 0:
raise ValueError(f"leftover bytes: {leftover}")
result = cb(obj)

# Unpack dictionary arguments, allowing for more pythonic callbacks with
# named arguments.
if isinstance(obj, dict):
result = cb(**obj)
else:
result = cb(obj)

if result is None:
return None
return self.result_type.serialize(result)
Expand Down