[FIRRTL] Add InferDomains pass #8877
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
dev/seldridge/firrtl-infer-domains
branch
2 times, most recently
from
e1ae48d to
a17ada0
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-domains-operation-approach
branch
2 times, most recently
from
df67311 to
7e543de
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-infer-domains
branch
from
a17ada0 to
f0512f4
Compare
Base automatically changed from
dev/seldridge/firrtl-domains-operation-approach
to
main
August 30, 2025 19:36
Add a pass that does domain inference and checking. This is used to verify the legality of a FIRRTL circuit with respect to its domains. E.g., this pass is intended to be used for checking for illegal clock domain crossings. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/firrtl-infer-domains
branch
from
f0512f4 to
a12e326
Compare
uenoku
reviewed
Sep 4, 2025
Comment on lines
+170
to
+179
| std::unique_ptr<mlir::Pass> clonePass() const override { | ||
| return std::make_unique<InferDomainsPass>(); | ||
| } |
There was a problem hiding this comment.
Why do we need to define clonePass?
| // domains | ||
| if (!op->getOperands().empty()) { | ||
| Value firstOperand = op->getOperand(0); | ||
| for (auto operand : op->getOperands()) { |
Comment on lines
+420
to
+422
| if (hasErrors) { | ||
| signalPassFailure(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (hasErrors) { | |
| signalPassFailure(); | |
| } | |
| if (hasErrors) | |
| signalPassFailure(); |
Comment on lines
+61
to
+62
| // pointer comparison is only stable within a run of MLIR and should not be | ||
| // relied upon for determinism outside of a run. |
There was a problem hiding this comment.
Isn't non-deterministic still visible outside soon after we attached ? I think you can sort by properlyDominate
| // Set the merged domain sequence on the new representative | ||
| if (!mergedDomains.empty()) { | ||
| Value newRep = equivalenceClasses.getLeaderValue(rep1); | ||
| concreteDomains[newRep] = mergedDomains; |
There was a problem hiding this comment.
I think this has a lifetime issue. mergedDomains points to a reference to concreteDomains but concreteDomains[newRep] could grow capacity and invalidate the mergedDomains. You might want to change the type concreateDomains to DenseMap<Value, std::uninque_ptr<SmallVector<..>>>.
| if (isa<DomainType>(port.type)) { | ||
| newDomainInfo.push_back(port.domains | ||
| ? port.domains | ||
| : ArrayAttr::get(module.getContext(), {})); |
There was a problem hiding this comment.
nit: Please hoist empty array out of loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pass that does domain inference and checking. This is used to verify the legality of a FIRRTL circuit with respect to its domains. E.g., this pass is intended to be used for checking for illegal clock domain crossings.