Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Move GC after AssignOutputDirs. #8112

Conversation

dtzSiFive
Copy link
Contributor

This allows GC to set the output directory information of the SV operations it creates when lowering firrtl.view (instead of other way around).

Extend comment about new placement, not yet implemented.
@dtzSiFive dtzSiFive added the FIRRTL Involving the `firrtl` dialect label Jan 22, 2025
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change scares me. Gotta trust the tests, though. 😬

@dtzSiFive dtzSiFive merged commit db262be into llvm:main Jan 23, 2025
5 checks passed
@dtzSiFive dtzSiFive deleted the feature/move-grand-central-after-assign-output-dirs branch January 23, 2025 14:25
dtzSiFive added a commit that referenced this pull request Jan 23, 2025
Simply propagate the "output_file" information entirely
to any generated sv.interface created during lowering.

cc #8112 .

No change of behavior for annotation-based views.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants