[circt-test] Allow tests to filter according to test runners #8084
+212
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
approved these changes
Jan 15, 2025
tools/circt-test/circt-test.cpp
Outdated
Comment on lines
251
to
281
| auto attr = attrs.get(attrName); | ||
| if (!attr) | ||
| return; | ||
| if (auto arrayAttr = dyn_cast<ArrayAttr>(attr)) { | ||
| for (auto elementAttr : arrayAttr.getValue()) | ||
| if (auto stringAttr = dyn_cast<StringAttr>(elementAttr)) | ||
| names.insert(stringAttr); | ||
| return; | ||
| } | ||
| if (auto stringAttr = dyn_cast<StringAttr>(attr)) | ||
| names.insert(stringAttr); |
There was a problem hiding this comment.
Allowing null/array/string looks a bit too untyped to me. Can we at least reject StringAttr case? Also it would be nice to have a document for parameters.
There was a problem hiding this comment.
Yeah that's a good point. I'll make this fallible and add some error reporting. I can add the attributes that have some specific meaning to the op definition, and then later on we can maybe move them to the docs where they're easier for users to find?
fabianschuiki
force-pushed
the
fschuiki/runner-filters
branch
from
c6358ab to
3088e8d
Compare
Interpret the `require_runners` and `exclude_runners` attributes on formal tests as a filter for the potential runners that can execute a test. If the set of required runners is not empty, a runner from this set is picked. Tests for which no runner is available report as "unsupported", for example if none of the available runners match the filter.
fabianschuiki
force-pushed
the
fschuiki/runner-filters
branch
from
3088e8d to
beb4d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpret the
require_runnersandexclude_runnersattributes on formal tests as a filter for the potential runners that can execute a test. If the set of required runners is not empty, a runner from this set is picked. Tests for which no runner is available report as "unsupported", for example if none of the available runners match the filter.