Skip to content

Commit

Permalink
[FIRRTL][GC] NFC: touchup file separator FileCheck match.
Browse files Browse the repository at this point in the history
  • Loading branch information
dtzSiFive committed Jan 24, 2025
1 parent 45af0ea commit 26d80cf
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions test/Dialect/FIRRTL/grand-central-view.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -583,30 +583,30 @@ firrtl.circuit "SetOutputDir" {
// CHECK-NEXT: !sv.interface<@[[OUTSYM_4:.+]]>

// CHECK: sv.interface @[[OUTSYM_1]]
// CHECK-SAME: output_file = #hw.output_file<"path{{/|\\\\}}">
// CHECK-SAME: output_file = #hw.output_file<"path{{[/|\]}}">
// CHECK: sv.verbatim "[[SUB_1:.+]] sub();"

// CHECK: sv.interface @[[SUB_1]]
// CHECK-SAME: output_file = #hw.output_file<"path{{/|\\\\}}">
// CHECK-SAME: output_file = #hw.output_file<"path{{[/|\]}}">

// CHECK: sv.interface @[[OUTSYM_2]]
// CHECK-SAME: output_file = #hw.output_file<"other{{/|\\\\}}", excludeFromFileList>
// CHECK-SAME: output_file = #hw.output_file<"other{{[/|\]}}", excludeFromFileList>
// CHECK: sv.verbatim "[[SUB_2:.+]] sub();"

// CHECK: sv.interface @[[SUB_2]]
// CHECK-SAME: output_file = #hw.output_file<"other{{/|\\\\}}", excludeFromFileList>
// CHECK-SAME: output_file = #hw.output_file<"other{{[/|\]}}", excludeFromFileList>

// Place interfaces in same /file/ if module is output to specific file.
// CHECK: sv.interface @[[OUTSYM_3]]
// CHECK-SAME: output_file = #hw.output_file<"dir{{/|\\\\}}file.sv">
// CHECK-SAME: output_file = #hw.output_file<"dir{{[/|\]}}file.sv">
// CHECK: sv.verbatim "[[SUB_3:.+]] sub();"

// CHECK: sv.interface @[[SUB_3]]
// CHECK-SAME: output_file = #hw.output_file<"dir{{/|\\\\}}file.sv">
// CHECK-SAME: output_file = #hw.output_file<"dir{{[/|\]}}file.sv">

// CHECK: sv.interface @[[OUTSYM_4]]
// CHECK-SAME: output_file = #hw.output_file<"include{{/|\\\\}}", includeReplicatedOps>
// CHECK-SAME: output_file = #hw.output_file<"include{{[/|\]}}", includeReplicatedOps>
// CHECK: sv.verbatim "[[SUB_4:.+]] sub();"

// CHECK: sv.interface @[[SUB_4]]
// CHECK-SAME: output_file = #hw.output_file<"include{{/|\\\\}}", includeReplicatedOps>
// CHECK-SAME: output_file = #hw.output_file<"include{{[/|\]}}", includeReplicatedOps>

3 comments on commit 26d80cf

@fabianschuiki
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, but the Windows build seems to be unhappy 🙁. Maybe the backslash needs escaping, something like [/|\\]?

@seldridge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in: b951ce7

@dtzSiFive
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry about that folks!

Please sign in to comment.