-
Notifications
You must be signed in to change notification settings - Fork 27
Right click menus #82
base: master
Are you sure you want to change the base?
Conversation
} | ||
}; | ||
|
||
var windows_linux_template = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man, this seems like a lot of duplication just to show keyboard shortcuts. 😦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these actually identical?
{ | ||
label: 'Comment', | ||
accelerator: 'Shift+CmdOrCtrl+C', | ||
click: comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this one on the context menu, and I'm not seeing any functionality out of it. What is it supposed to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obvious question but did you pull the latest? I just added this commit late yesterday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled it at 11pm. :-) I'll figure it out. Probably just a user error.
On Jan 29, 2016 7:51 AM, "3-john-4" [email protected] wrote:
In src/browser/context-menu-template.js
#82 (comment)
:
- },
- {
- type: 'separator'
- },
- {
- label: 'Reload',
- accelerator: 'CmdOrCtrl+R',
- click: reload
- },
- {
- type: 'separator'
- },
- {
- label: 'Comment',
- accelerator: 'Shift+CmdOrCtrl+C',
- click: comment
Obvious question but did you pull the latest? I just added this commit
late yesterday.—
Reply to this email directly or view it on GitHub
https://github.com/HackerHappyHour/matterfront/pull/82/files#r51261992.
Nitpicks:
Otherwise, 👍 |
Added edit capabilities via right click context menu. See https://github.com/StateFarmIns/matterfront/issues/17