Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Right click menus #82

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Right click menus #82

wants to merge 6 commits into from

Conversation

3-john-4
Copy link

Added edit capabilities via right click context menu. See https://github.com/StateFarmIns/matterfront/issues/17

}
};

var windows_linux_template = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, this seems like a lot of duplication just to show keyboard shortcuts. 😦

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these actually identical?

{
label: 'Comment',
accelerator: 'Shift+CmdOrCtrl+C',
click: comment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this one on the context menu, and I'm not seeing any functionality out of it. What is it supposed to do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Here's what I'm seeing. Once you select a post you can select Comment and it will add the > followed by the selected text in the new entry field.
contextmenu

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obvious question but did you pull the latest? I just added this commit late yesterday.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled it at 11pm. :-) I'll figure it out. Probably just a user error.
On Jan 29, 2016 7:51 AM, "3-john-4" [email protected] wrote:

In src/browser/context-menu-template.js
#82 (comment)
:

  • },
  • {
  • type: 'separator'
  • },
  • {
  • label: 'Reload',
  • accelerator: 'CmdOrCtrl+R',
  • click: reload
  • },
  • {
  • type: 'separator'
  • },
  • {
  • label: 'Comment',
  • accelerator: 'Shift+CmdOrCtrl+C',
  • click: comment

Obvious question but did you pull the latest? I just added this commit
late yesterday.


Reply to this email directly or view it on GitHub
https://github.com/HackerHappyHour/matterfront/pull/82/files#r51261992.

@lloeki
Copy link
Owner

lloeki commented Feb 22, 2016

Nitpicks:

  • I'd rather have the last entry be Quote instead of Comment
  • not sure Reload warrants an entry there
  • Undo/Redo are misleading as they're useful only in a text field

Otherwise, 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants