CMake: Add deprecated_names option to sundials_option#842
Open
CMake: Add deprecated_names option to sundials_option#842
Conversation
gardner48
requested review from
balos1,
cswoodward and
drreynolds
as code owners
Member
Author
|
This PR extracts some of the changes from #837 to consistently prefix CMake options with |
balos1
reviewed
Feb 4, 2026
balos1
approved these changes
Feb 4, 2026
| unset(SUPERLUDIST_ENABLE CACHE) | ||
| endif() | ||
| # --------------------------------------------------------------- | ||
| # Deprecated options that can not use the DEPRECATED_NAMES option to |
Member
There was a problem hiding this comment.
Suggested change
| # Deprecated options that can not use the DEPRECATED_NAMES option to | |
| # Deprecated options that can not use the DEPRECATED_NAMES option of |
balos1
reviewed
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPRECATED_NAMESoption tosundials_optionto handle deprecating an existing option's nameDEPRECATED_NAMES